Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle leading comments in queries #164

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Handle leading comments in queries #164

merged 7 commits into from
Jun 10, 2021

Conversation

macbre
Copy link
Owner

@macbre macbre commented Jun 10, 2021 •
edited
Loading

Fixes #163

Example case

    assert ["bar"] == Parser("/* foo */ INSERT IGNORE INTO bar VALUES (1, '123', '2017-01-01');").tables

@macbre macbre added the bug label Jun 10, 2021
@macbre macbre added this to the v2.3 milestone Jun 10, 2021
@macbre macbre requested a review from collerek June 10, 2021 13:57
@macbre macbre marked this pull request as ready for review June 10, 2021 13:57
@macbre macbre removed this from the v2.3 milestone Jun 10, 2021
@macbre macbre mentioned this pull request Jun 10, 2021
Closed
@macbre macbre requested a review from collerek June 10, 2021 15:18
@macbre macbre added this to the v2.2.1 milestone Jun 10, 2021
@macbre macbre merged commit bbe8d25 into master Jun 10, 2021
@macbre macbre deleted the handle-leading-comments branch June 10, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collerek collerek Awaiting requested review from collerek collerek is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging this pull request may close these issues.

Parser raises an exception for not supported query type when query starts with a comment
2 participants
@macbre @collerek