Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce phantomjs2 engine that uses PhantomJS 2.0 binary #531

Merged
merged 12 commits into from
Jul 11, 2015
Merged

Introduce phantomjs2 engine that uses PhantomJS 2.0 binary #531

merged 12 commits into from
Jul 11, 2015

Conversation

macbre
Copy link
Owner

@macbre macbre commented Jun 5, 2015

PhantomJS 2.0 features:

Linux distros support:

  • Ubuntu 14 - sudo apt-get install libicu52 libjpeg8 libfontconfig libwebp5
  • Travis CI (Ubuntu 12.04)
  • Debian 8 (missing libjpeg8 package) - fixed by binary with statically-linked binaries

See #488 / waiting for statically built PhantomJS 2.x

Verified to work on the following amd64 distros:

  • Debian 8
  • Ubuntu 12.04 LTS (aka Precise)
  • Travis CI environment (Ubuntu 12.04)

@macbre macbre closed this Jun 5, 2015
@macbre macbre deleted the phantomjs-2.x-issue-488 branch June 5, 2015 18:20
@macbre macbre restored the phantomjs-2.x-issue-488 branch June 5, 2015 18:34
@macbre macbre reopened this Jun 5, 2015
@macbre macbre added this to the Roadmap milestone Jun 5, 2015
@macbre
Do not freeze the console object - revert a fix for #230
f2b8fe0 
Was throwing "TypeError: Attempting to change value of a readonly property."
@macbre
Fix JS error in phantomas.getDOMPath helper
21e87e4 
TypeError: undefined is not an object (evaluating 'Array.prototype.indexOf.call(node.parentNode.children, node)')
@macbre
Copy link
Owner Author

macbre commented Jun 6, 2015

PhantomJS 2 binary fails to run on Travis:

Command failed: /home/travis/build/macbre/phantomjs2-npm/lib/phantom/bin/phantomjs: error while loading shared libraries: libwebp.so.5: cannot open shared object file: No such file or directory

Solved in macbre/phantomjs2-npm@8d070a5

@macbre macbre mentioned this pull request Jul 2, 2015
Closed
@macbre macbre changed the title Use PhantomJS 2.0 binaries Introduce phantomjs2 engine that uses PhantomJS 2.0 binary Jul 3, 2015
@macbre macbre modified the milestones: v1.12, Roadmap Jul 3, 2015
@konklone konklone mentioned this pull request Jul 3, 2015
Closed
macbre added a commit to macbre/phantomjs2-npm that referenced this pull request Jul 4, 2015
@macbre
Allow phantomas to use two versions of PhantomJS
3002c83 
See macbre/phantomas#531
macbre added a commit to macbre/phantomjs2-npm that referenced this pull request Jul 4, 2015
@macbre
Allow phantomas to use two versions of PhantomJS
e007d8e 
See macbre/phantomas#531
macbre added a commit that referenced this pull request Jul 11, 2015
@macbre
Register webkit2 engine that uses PhantomJS 2.x (#531)
f375819
macbre pushed a commit that referenced this pull request Jul 11, 2015
Merge pull request #531 from macbre/phantomjs-2.x-issue-488
b683cf6 
Introduce phantomjs2 engine that uses PhantomJS 2.0 binary
@macbre macbre merged commit b683cf6 into devel Jul 11, 2015
@macbre macbre deleted the phantomjs-2.x-issue-488 branch July 11, 2015 11:19
@macbre macbre mentioned this pull request Jul 11, 2015
Closed
macbre added a commit that referenced this pull request Jul 11, 2015
@macbre
Do not fail when importing not existing engine (see #531)
559a441
macbre added a commit that referenced this pull request Sep 12, 2015
@macbre
Engines: update README.md
289be30 
See #553 and #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement internals
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
1 participant
@macbre