Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempted fix for PyYaml CI failures #25

Closed
wants to merge 4 commits into from

Conversation

midsandhighs
Copy link

@midsandhighs midsandhighs commented Mar 31, 2021

Unsure if this will actually solve, there was a minor version release / hotfix to PyYaml one day after 5.4 release after having to do with multiarch build problems yaml/pyyaml#480 <- only commit in the release which was a fix for yaml/pyyaml#478, which mentions CI builds failing due to the 5.4 release

Most of their tests are against 3.8, however.

@erikng
Copy link
Member

erikng commented Apr 1, 2021

Looks like there are some conflicts going on that need to be fixed. Once that's done the CI job can attempt to build a universal python.

@erikng erikng changed the base branch from dependabot/pip/pyyaml-5.4 to main April 1, 2021 02:35
@erikng
Copy link
Member

erikng commented Apr 1, 2021

Looks like it's the same issue :/

@midsandhighs
Copy link
Author

I played around for a bit with the logic to determine where the check failed but didn't find anything easy in 30 minutes.

Going to close this but keep hacking away at build_python_framework_pkgs.zsh to see if I can get some more verbose / useful error messages. At the bare minimum, I think we can improve the logic to output what dynamic and shared libraries are not matching

@midsandhighs midsandhighs deleted the pyyamlfix branch April 1, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants