Skip to content

Symfony 7.3 beta incompatibility #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mac-cain13 merged 3 commits into from
Jun 2, 2025
Merged

Symfony 7.3 beta incompatibility #61

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbae767
Symfony 7.3 beta incompatibility
umpirsky May 30, 2025
f60fd2c
Fix callable
umpirsky May 30, 2025
6116b08
ypeError: Wrep\Daemonizable\Command\EndlessCommand::handleSignal(): A…
umpirsky May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/Wrep/Daemonizable/Command/EndlessCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ public function __construct(?string $name = null)
$this->addOption('run-once', null, InputOption::VALUE_NONE,
'Run the command just once, do not go into an endless loop');
$this->addOption('detect-leaks', null, InputOption::VALUE_NONE, 'Output information about memory usage');
}

// Set our runloop as the executable code
parent::setCode([$this, 'runloop']);
public function __invoke(InputInterface $input, OutputInterface $output): int
{
return $this->runloop($input, $output);
}

/**
Expand Down Expand Up @@ -78,7 +80,7 @@ public function run(InputInterface $input, OutputInterface $output): int
*
* @param int $signal The signal code to handle
*/
public function handleSignal(int $signal): void
public function handleSignal(int $signal, array|int|false $previousExitCode = 0): int|false
Copy link
Contributor Author

@umpirsky umpirsky May 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added array here because of:

1) Tests\Wrep\Daemonizable\Command\EndlessCommandTest::testInterruptSigtermFromDifferentContext
TypeError: Wrep\Daemonizable\Command\EndlessCommand::handleSignal(): Argument #2 ($previousExitCode) must be of type int|false, array given, called in tests/Wrep/Daemonizable/Command/EndlessCommandTest.php on line 117

src/Wrep/Daemonizable/Command/EndlessCommand.php:83
tests/Wrep/Daemonizable/Command/EndlessCommandTest.php:117
vendor/symfony/console/Command/Command.php:318
src/Wrep/Daemonizable/Command/EndlessCommand.php:75
tests/Wrep/Daemonizable/Command/EndlessCommandTest.php:102

Soemthing that should probably be addressed later on.

{
switch ($signal) {
// Shutdown signals
Expand All @@ -87,6 +89,8 @@ public function handleSignal(int $signal): void
$this->shutdown();
break;
}

return false;
}

/**
Expand Down