#2112

mabel-dev · Dec 22, 2024 · 9822658 · 9822658
1 parent 7c9df82
commit 9822658
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 18 deletions.
diff --git a/opteryx/operators/aggregate_and_group_node.py b/opteryx/operators/aggregate_and_group_node.py
@@ -102,7 +102,7 @@ def config(self):  # pragma: no cover
 
     @property
     def name(self):  # pragma: no cover
-        return "Group"
+        return "Group By"
 
     def execute(self, morsel: pyarrow.Table, **kwargs):
         if morsel == EOS:

diff --git a/opteryx/operators/async_read_node.py b/opteryx/operators/async_read_node.py
@@ -192,9 +192,7 @@ def execute(self, morsel, **kwargs) -> Generator:
                     arrow_schema = morsel.schema
 
                 self.statistics.blobs_read += 1
-                self.records_out += morsel.num_rows
                 self.statistics.rows_read += morsel.num_rows
-                self.bytes_out += morsel.nbytes
 
                 yield morsel
             except Exception as err:

diff --git a/opteryx/operators/function_dataset_node.py b/opteryx/operators/function_dataset_node.py
@@ -142,8 +142,6 @@ def execute(self, morsel, **kwargs) -> Generator:
         else:
             table = data
 
-        self.records_out += table.num_rows
-        self.bytes_out += table.nbytes
         self.statistics.columns_read += len(table.column_names)
 
         yield table
diff --git a/opteryx/operators/read_node.py b/opteryx/operators/read_node.py
@@ -221,9 +221,7 @@ def execute(self, morsel, **kwargs) -> Generator:
 
             self.statistics.time_reading_blobs += time.monotonic_ns() - start_clock
             self.statistics.blobs_read += 1
-            self.records_out += morsel.num_rows
             self.statistics.rows_read += morsel.num_rows
-            self.bytes_out += morsel.nbytes
             yield morsel
             start_clock = time.monotonic_ns()
         if morsel:

diff --git a/opteryx/planner/cost_based_optimizer/strategies/constant_folding.py b/opteryx/planner/cost_based_optimizer/strategies/constant_folding.py
@@ -125,17 +125,6 @@ def fold_constants(root: Node, statistics: QueryStatistics) -> Node:
                 root.left.schema_column = root.schema_column
                 statistics.optimization_constant_fold_reduce += 1
                 return root.left  # anything
-            if (
-                root.value == "Divide"
-                and root.right.node_type == NodeType.IDENTIFIER
-                and root.left.node_type == NodeType.IDENTIFIER
-                and root.right.schema_column.identity == root.left.schema_column.identity
-            ):
-                # anything / itself = 1 (0 is an exception)
-                node = build_literal_node(1, root, OrsoTypes.INTEGER)
-                statistics.optimization_constant_fold_reduce += 1
-                node.schema_column = root.schema_column
-                return node
 
         if root.node_type == NodeType.COMPARISON_OPERATOR:
             if (

diff --git a/tests/sql_battery/test_shapes_and_errors_battery.py b/tests/sql_battery/test_shapes_and_errors_battery.py
@@ -2180,6 +2180,8 @@
         # 2059
         ("SELECT g FROM generate_series(10) as g CROSS JOIN UNNEST (g) as g1", 0, 0, TypeError),
         ("SELECT DISTINCT l FROM (SELECT split('a b c d e f g h i j', ' ') as letters) as plet CROSS JOIN UNNEST (letters) as l", 10, 1, None),
+        # 2112
+        ("SELECT id FROM $planets WHERE surface_pressure / surface_pressure is null", 5, 1, None),
 ]
 # fmt:on