Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.6.14 #388

Closed
wants to merge 11 commits into from
Closed

0.6.14 #388

wants to merge 11 commits into from

Conversation

joocer
Copy link
Collaborator

@joocer joocer commented Jul 16, 2023

No description provided.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
74.5% 74.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #388 (61dde91) into main (37537fa) will decrease coverage by 0.53%.
The diff coverage is 62.27%.

❗ Current head 61dde91 differs from pull request most recent head 71fa7bb. Consider uploading reports for the commit 71fa7bb to get more accurate results

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   89.57%   89.04%   -0.53%     
==========================================
  Files         126      119       -7     
  Lines        5459     5004     -455     
==========================================
- Hits         4890     4456     -434     
+ Misses        569      548      -21     
Files Coverage Δ
mabel/adapters/disk/disk_writer.py 100.00% <100.00%> (ø)
...bel/adapters/google/google_cloud_storage_writer.py 100.00% <100.00%> (ø)
mabel/adapters/minio/minio_reader.py 100.00% <ø> (ø)
mabel/data/internals/dictset.py 86.73% <100.00%> (-0.64%) ⬇️
mabel/data/internals/dnf_filters.py 91.30% <100.00%> (+19.17%) ⬆️
mabel/data/internals/group_by.py 90.72% <100.00%> (-0.10%) ⬇️
mabel/data/internals/index.py 87.30% <100.00%> (ø)
mabel/data/readers/internals/base_inner_reader.py 93.96% <100.00%> (+10.86%) ⬆️
mabel/data/readers/internals/inline_functions.py 82.40% <100.00%> (ø)
mabel/data/readers/internals/parallel_reader.py 50.45% <100.00%> (ø)
... and 56 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joocer
Copy link
Collaborator Author

joocer commented Jul 16, 2023

Changes

  • Removal of some unused code, particularly relating to caching and indexes (still more to remove) - [the codebase has shrunk 11.5%]
  • Use Orso for schema functionality, removal of Mabel schema code
  • Removal of unused requirements.txt entries
  • Pydantic handled through duck-typing rather than importing

Impact

  • Existing Type validations may fail, two scenarios in particular:
    • NUMERIC deprecated, interpreted as DOUBLE which does not accept integers, this means some existing NUMERIC fields will fail schema validation. NUMERIC should be removed and replaced with DOUBLE (floating point), INTEGER (whole number) or DECIMAL (fixed decimal).
    • TIMESTAMP is now strictly a date and time field, this means some existing TIMESTAMP fields will fail schema validation if the value is a DATE only (no time component). TIMESTAMP is not deprecated, but instances where the value is a date only should use DATE, where the value is a time only should use TIME.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
63.9% 63.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@joocer joocer closed this Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant