Repository navigation
perf(web): lazy-load the ambient appearance hover card - #91
Merged
Merged
Conversation
The hover card moved out of chatAmbientEffects.tsx, which the Marcode fork seam exempts from the shadcn rules, into a new file that was not exempt. Its two raw cyan classes failed no-raw-colors in CI. The new file joins the same exemption list.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The ambient appearance hover card moves into its own module,
ChatAmbientAppearanceHoverCard, loaded withReact.lazy. The picker button renders immediately as theSuspensefallback, so it never waits on the import.The new file joins the Marcode fork seam's lint exemption list in
vite.config.ts, as the file it was extracted from already is.Why
The hover card only matters after a pointer rests on the picker, but its code was part of the module that renders the chat header. Loading it separately keeps hover-only code out of that module.
Checked in a running app: the module is fetched as its own request, the card appears on hover and hides on mouse-out, and a click still opens the appearance popover.
Checklist