minimal blog - first commit #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

alfiyanm wants to merge 1 commit into ma-pp:master from alfiyanm:master

alfiyanm commented Nov 30, 2018 •

edited

Loading

Please review this codes of github page. I hope you like this one.


          minimal blog - first commit

95848ec

Member

muizidn commented Nov 30, 2018 via email

Thanks. Unfortunately currently I am out. Will check it soon.

On Fri, 30 Nov 2018 at 10:13, Muchlas Alfiyan ***@***.***> wrote: Please review this codes. I hope you like this one. ------------------------------ You can view, comment on, or merge this pull request online at: #9 Commit Summary - minimal blog - first commit File Changes - *M* .gitignore <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-0> (2) - *M* README.md <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-1> (75) - *A* Screenshot1.png <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-2> (0) - *A* Screenshot2.png <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-3> (0) - *M* _config.yml <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-4> (20) - *A* _includes/comments.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-5> (21) - *A* _includes/head.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-6> (9) - *A* _includes/header.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-7> (16) - *A* _includes/minutes-to-read.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-8> (7) - *A* _layouts/default.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-9> (10) - *A* _layouts/page.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-10> (8) - *A* _layouts/post.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-11> (17) - *A* _posts/2018-11-22-hello-developers.md <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-12> (23) - *A* _posts/2018-11-22-what-is-muslim-app.md <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-13> (25) - *A* _sass/_base.scss <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-14> (254) - *A* _sass/_layout.scss <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-15> (118) - *A* _sass/_syntax-highlighting.scss <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-16> (61) - *A* _site/README.md <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-17> (31) - *A* _site/Screenshot1.png <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-18> (0) - *A* _site/Screenshot2.png <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-19> (0) - *A* _site/about/index.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-20> (52) - *A* _site/app/index.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-21> (72) - *A* _site/contact/index.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-22> (54) - *A* _site/css/main.css <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-23> (538) - *A* _site/feed.xml <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-24> (84) - *A* _site/hello-developers/index.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-25> (102) - *A* _site/index.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-26> (69) - *A* _site/mappicon.png <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-27> (0) - *A* _site/what-is-muslim-app/index.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-28> (105) - *A* about.md <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-29> (7) - *A* app.md <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-30> (24) - *A* contact.md <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-31> (9) - *A* css/main.scss <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-32> (6) - *A* feed.xml <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-33> (30) - *A* index.html <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-34> (20) - *A* mappicon.png <https://github.com/ma-pp/ma-pp.github.io/pull/9/files#diff-35> (0) Patch Links: - https://github.com/ma-pp/ma-pp.github.io/pull/9.patch - https://github.com/ma-pp/ma-pp.github.io/pull/9.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASdYQ4zze3yeRdsoKfAGwsVPI2mUQKKjks5u0KI7gaJpZM4Y67ij> .

Member

muizidn commented Nov 30, 2018

Good for your first contribution experience. I appreciate it.
But it will be better if you make your pull request to be something production ready.
For now, I consider to close this pull request because not ready for deployment.
I'll be in touch.

Author

alfiyanm commented Dec 1, 2018 •

edited

Loading

Ok, at least this is my first open-source contribution, i just learn about good contribution and serve my best. thank you for feedback.

Member

muizidn commented Dec 3, 2018 via email

Keep up your good work!

On Sat, 1 Dec 2018 at 07:15, Muchlas Alfiyan ***@***.***> wrote: Ok, at least this is my first open-source contribution, i just learn about good contribution and well-production. thank you for feedback. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASdYQ3rKsDWeu9RUN8ztq8dceNmARiE8ks5u0coLgaJpZM4Y67ij> .

Member

muizidn commented Dec 29, 2018

I'll make some changes @alfiyanm

muizidn requested a review from ilhamjulianto

December 29, 2018 12:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet