Skip to content

Conversation

@markvdouw
Copy link
Contributor

@markvdouw markvdouw commented Nov 10, 2022

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/stable/.github/workflows/pr-branch-check-name.yml

Summary

  • Adding a simple test to ShopViewModel

Testing Plan

  • Adding a unit test

Reference Issue

@mchuangatmp mchuangatmp self-requested a review November 10, 2022 16:29
Copy link
Contributor

@mchuangatmp mchuangatmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchuangatmp mchuangatmp merged commit 385ec18 into mParticle:development Nov 10, 2022
thomson-t added a commit that referenced this pull request Nov 24, 2025
* feat: Adding simple sample instrumentation test for ShopViewModel (#151)

* feat: Update dependencies and implement Rokt (#279)

* feat: sideloaded kit integration (#211)

* Sideloaded kit integration

* Testing sideloading integration

* Fix dependency version

* Changes due to comments

* Adding kitId in constructor due to change in architecture

* Implementing default functions from KitIntegration

* Adding minimal sideloading kit example and kit-base dependency

* Base updates for AGP

* Remove excessive logging

* Update deps to use BOM and add Rokt

* Add Rokt overlay placement post checkout

* Add Rokt close implementation

* Add event logging and auto close

* Migrate to toml version management

* Add lint baseline

* Add standard files

* Migrate missed plugins

* Add versions to toml file

* Add permissions

* Bump upload artifact version

* Add concurrency

* Remove main qualifier

* Use local reference

* Bump versions

* Change runner to recommended by reactivecircus

* Bump gradle version

* Update settings.gradle.kts

---------

Co-authored-by: markvdouw <v-mvanderouw@mparticle.com>

* fix: desugar build error

---------

Co-authored-by: markvdouw <mark.vdouw@gmail.com>
Co-authored-by: James Newman <james.newman@rokt.com>
Co-authored-by: markvdouw <v-mvanderouw@mparticle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants