Change TS types to use string literals instead enums, and added missing methods #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savelichalex
commented
Apr 12, 2019
|
|
||
| module.exports = { | ||
| ...RNSensitiveInfo, | ||
| setInvalidatedByBiometricEnrollment() { |
There was a problem hiding this comment.
Since that method is not available on iOS it's needed to add a guard in user code, but I think it's better to handle that in the library. (At least we have them on TS typings, and can't separate that for different OS).
Btw, there are isHardwareDetected() and hasEnrolledFingerprints() methods, that needed to be guarded in a same way, but it will be unfair to do nothing, and it will be hard to debug, why nothing happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RNSensitiveInfoAccessControlOptionsandRNSensitiveInfoAttrAccessibleOptionswas changed to string literals by following reasons:enums in declaration files should be declared asconstto be able to import it to source code, but it works not well for instance with babel;Some available methods was missing, but are using in docs and examples.