Conversation
|
This looks pretty good aside from how you added the ClusterIssuer template. Files that dont get templated should go in the files directory, any files that get templated should go into a template directory. this is kind of an ansible standard, i think. Right now you are looping over all the *.j2 files to apply, i am not sure that is actually working? |
I moved the ClusterIssuer templates into the templates dir, good catch, that was mostly a case of updating the self signed template in place. As for looping over the files, I was following the pattern used for deploying the self-signed issuer, just adding steps to template out the files, and I can at least confirm that it works when destroying the self signed issuer and rerunning ansible |
group_vars/all.yml
Outdated
| nginx_helm_chart_repo: "https://kubernetes.github.io/ingress-nginx" | ||
| nginx_helm_chart_version: "4.5.2" | ||
| nginx.prometheus_enabled: true | ||
| nginx_oci_subnet_id: "" |
There was a problem hiding this comment.
Lets add a comment to this explaining what this field is for. Nothing too crazy, but at least mention that it is only needed when using the OCI platform.
| @@ -1,4 +1,4 @@ | |||
| apiVersion: batch/v1beta1 | |||
| apiVersion: batch/v1 | |||
There was a problem hiding this comment.
nice, good catch. This should be fine as that new API was rolled out long enough ago
2 participants
No description provided.