Skip to content

Conversation

@Jan-E
Copy link
Collaborator

@Jan-E Jan-E commented Oct 24, 2019

This PR solves a couple of issues.

PHP 7.4: change ulong to unsigned long and uint to uint32_t

Windows builds:

  • Fix operator error which does not exist in Visual Studio
  • Check for OpenSSL 1.1.1 libs first, then for OpenSSL 1.0.2 libs
  • Add Curl dependent libs

@codecov
Copy link

codecov bot commented Oct 24, 2019

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files          42       42           
  Lines        9686     9686           
=======================================
  Hits         8444     8444           
  Misses       1242     1242
Impacted Files Coverage Δ
src/php_http_curl.c 85.71% <ø> (ø) ⬆️
src/php_http_client_curl.c 81.91% <ø> (ø) ⬆️
src/php_http_filter.c 81.64% <ø> (ø) ⬆️
src/php_http_message_parser.c 85.66% <100%> (ø) ⬆️
src/php_http_options.c 75% <100%> (ø) ⬆️
src/php_http_etag.c 98.07% <100%> (ø) ⬆️
src/php_http_encoding.c 88.25% <100%> (ø) ⬆️
src/php_http_querystring.c 93.28% <100%> (ø) ⬆️
src/php_http_message_body.c 87.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567a611...b2f41a2. Read the comment docs.

@Jan-E
Copy link
Collaborator Author

Jan-E commented Oct 24, 2019

The same results in the Travis check. Merging.

@Jan-E
Copy link
Collaborator Author

Jan-E commented Oct 25, 2019

@m6w6 Is it time for a new release with the Windows fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant