Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restarted workflows not triggering runners #823

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Fix restarted workflows not triggering runners #823

merged 1 commit into from
Jul 15, 2022

Conversation

pavlovic-ivan
Copy link
Contributor

@pavlovic-ivan pavlovic-ivan commented Jun 27, 2022

This PR fixes the issue with runners not being created when a workflow is re-run. I've tried to keep changes to ILGPU repo as minimal as possible. Have in mind that there will be a more robust solution developed that i will discuss with @jgiannuzzi. With this PR, support is added when:

  • triggering a completely new workflow will trigger runners deployment (runner per cuda job)
  • restarting entire workflow when there are failed job will trigger runners deployment (runner per cuda job)
  • restarting only failing jobs will trigger runners deployment (runner per cuda job)

However, prerequisite before merging this PR is to create a Github action as described here and here. Have in mind that some of the already defined secrets might change as well. @jgiannuzzi i believe you would be of assistance here for this as i don't have access on that level to ILGPU repo.

@m4rs-mt i did not include any working examples in this PR as we did the demo of the solution several days ago. If needed, i can provide them.

Fixes https://github.com/G-Research/gr-oss/issues/204

@m4rs-mt m4rs-mt merged commit a1f50cc into m4rs-mt:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants