Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation primer fixed step 3 instruction #750

Closed
wants to merge 1 commit into from

Conversation

hokb
Copy link

@hokb hokb commented Feb 16, 2022

added required (?) 'package' command

@m4rs-mt m4rs-mt added the bug label Feb 17, 2022
@m4rs-mt m4rs-mt added this to the v1.1 milestone Feb 17, 2022
@m4rs-mt
Copy link
Owner

m4rs-mt commented Feb 17, 2022

@hokb Thank you very much for your PR and welcome to the ILGPU community 🎉

@m4rs-mt
Copy link
Owner

m4rs-mt commented Feb 17, 2022

Would you also mind to agree on the copyright transfer on #598 before we merge this PR (because we currently don't have a CLA to sign)?.

@m4rs-mt m4rs-mt modified the milestones: v1.1, v1.2 Mar 4, 2022
added required (?) 'package' command
@m4rs-mt
Copy link
Owner

m4rs-mt commented Apr 1, 2022

@hokb Thanks again for your contribution to ILGPU. This issue was also addressed in #776, which included many improvements to the documentation. Since we did not receive a response from you regarding the copyright transfer, we were not able to merge your PR before #776. In any case, we would like to thank you for your efforts 🥇

@m4rs-mt m4rs-mt closed this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants