Skip to content

Fixed disassembly of Conv_R_Un opcode.#1356

Merged
MoFtZ merged 5 commits intobranch/v1.6.xfrom
fp_convert_15x
Mar 15, 2026
Merged

Fixed disassembly of Conv_R_Un opcode.#1356
MoFtZ merged 5 commits intobranch/v1.6.xfrom
fp_convert_15x

Conversation

@m4rs-mt
Copy link
Copy Markdown
Owner

@m4rs-mt m4rs-mt commented Jul 12, 2025

This PR fixes #1309 and supersedes #1310.

It introduces a new way to track type-dependent arguments in ILInstruction instances. During code generation, the current top-of-the-stack element, as well as the next instruction, can be matched against dependent type information and appropriate instructions on the IR level will be selected.

In case of conv.r we test the next operation and select type information accordingly:

float = conv.r.un -> conv.r4
double = conv.r.un -> conv.r8

Please note that this fix will have to be merged before #1355.

@m4rs-mt m4rs-mt added the bug label Jul 12, 2025
@m4rs-mt m4rs-mt added this to the v1.5.4 milestone Jul 12, 2025
@m4rs-mt m4rs-mt marked this pull request as draft July 12, 2025 17:45
@m4rs-mt m4rs-mt force-pushed the fp_convert_15x branch 2 times, most recently from 74362f0 to da9c78d Compare July 12, 2025 19:45
@m4rs-mt m4rs-mt marked this pull request as ready for review July 12, 2025 19:59
@MoFtZ MoFtZ changed the base branch from branch/v1.5.x to branch/v1.6.x December 15, 2025 10:34
@MoFtZ MoFtZ modified the milestones: v1.5.4, v1.6.0 Dec 15, 2025
@MoFtZ MoFtZ merged commit 7362cc1 into branch/v1.6.x Mar 15, 2026
44 checks passed
@MoFtZ MoFtZ deleted the fp_convert_15x branch March 15, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants