Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Copyright notices. #1

Conversation

kisg
Copy link

@kisg kisg commented Nov 11, 2023

No description provided.

@BastiaanOlij
Copy link

This will definitely need some more discussion. When it comes to copyright we follow the same rules and guidelines as the main Godot project. We've long been discussing, and should have taken action on, enforcing the standard copyright message on each file as the main Godot project does.

So something like:

Copyright (c) 2022-present Godot XR contributors (see CONTRIBUTORS.md).

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

It definitely doesn't make sense to stray away from this for trivial files like register_types.h/cpp, which are carbon copies of files found in any Godot module or Godot extension.

From what I understand authors of contributions have automatic copyright over their contributions but agree to have those fall under the MIT license as well.

What I think the main project doesn't do well (understandably due to its size) and what I don't mind seeing changed here, is attribution to who submitted the original code of larger systems. So having the standard copyright message followed by a:

Original implementation contributed by MattaKis Consulting Kft. (Migeran)

in the openxr_fb_scene_capture_extension_wrapper.h/cpp files.

@kisg
Copy link
Author

kisg commented Nov 12, 2023

@BastiaanOlij I totally agree, that a standard copyright header is the best way to move forward. Updated the PR based on your comment. Would this be acceptable for you?

Independently of this: wouldn't it make sense to rename the Github organization to GodotXR? AFAIR Github automatically creates a redirect from the old name to the new one.

@BastiaanOlij
Copy link

Yeah that looks good, only problem we'll need to think about is that if we want to make this part of the CI check, we need a separate section for the attribution. Or we just need to start being mindful of it ourselves.

@m4gr3d I think it would be good to make a separate PR introducing the copyright header on other files where we think this would be a good idea?

We also need to change the LICENSE file in the root to match this. It still refers to myself and Gergely holding primary copyright, which came from the early beginnings of the loader. we probably need to check the contributors.md file as well to make sure it is complete.

Copy link

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move forward with this, I like the changes kisg made. For now we'll manually include the license header.

I think we should make sure the LICENSE in the root matches too but we can fix that on the main repo.

And we'll need to see about adding this to other files in due course.

@m4gr3d m4gr3d force-pushed the add_meta_scene_capture_api_support branch from 7c4abae to 8b356af Compare November 21, 2023 19:09
@m4gr3d
Copy link
Owner

m4gr3d commented Nov 21, 2023

I cherry-picked the changes into the branch!

@m4gr3d m4gr3d closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants