Repository navigation
fix(engine): seq I/O skips retry loops, transaction-scoped runs, .unit. tests (v17) - #193
Merged
Merged
Conversation
…t. tests (v17) Hand-checked two seq I/O sites per corpus repo with 3+ sites (34). Six were false positives; three families are now guarded: - for (let attempt = 0; ; attempt++) had an empty label and missed the intentional-sequential rule (vscode) - consecutive reads passing a transaction/lock option share one connection, so Promise.all gains nothing (outline says so in a comment) - *.unit.ts files are tests (qwik) and are now non-production everywhere Old vs new engine on 19 repos: outline 77 -> 78, qwik 86 A+ -> 71 B (211 unit test files had been diluting its complexity ratios), the rest unchanged. Claude-Session: https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hand-checked 34 seq I/O sites (2 per corpus repo with 3+ sites): ~28 real, 6 false positives. Guards three generalizable families (condition-less retry for, transaction/lock option runs, .unit. test files). Old vs new engine on 19 repos: outline 77→78, qwik 86 A+→71 B because 211 *.unit.ts files were counted as production; others unchanged. Left as known: typeorm's same-connection this.query() runs and medusa's read-then-verify ordering.
https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq