Repository navigation
fix(engine): skip write-only GC-retention sets, gate oh-my-pi - #184
Merged
Merged
Conversation
- writeOnlyCollection: a Set that only holds references so objects are not collected is meant to be write-only (Electron Notification loses its click handler once collected). Skip retain/alive/live*/hold/pinned names [FP:write-only-gc-retention]: cindy liveNotifications, oh-my-pi retainedShells. - repo-gates: oh-my-pi requires a sentence written by the submitter and a personally exercised repro in every PR body. Claude-Session: https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI ์์ด์ ํธ ์ ์ฅ์ ์ฌ๋ฅ์์ ๋์จ ์คํ(์๊ฑฐ ๋ฐฉ์ง ๋ณด๊ด Set) ๊ฐ๋ ยท oh-my-pi ๊ฒ์ดํธ ๊ธฐ๋ก(๋ณธ์ธ ์์ฑ ๋ฌธ์ฅ ํ์).
https://claude.ai/code/session_01W9Mk18mBNfkPfgg3hYweKq