-
Notifications
You must be signed in to change notification settings - Fork 46
Fix py3 encodings #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- swapped pycrypto for pycryptodome due to the former not being maintained any longer
- swapped pycrypto for pycryptodome due to the former not being maintained any longer
Thanks for submitting a PR 🙂 Does this maintain compatibility with Python 2? If not, could you also update the readme? |
Also I know PEP8 prefers 4 spaces, but it's too ugly for me. I'd prefer 2 spaces - easier to see what else has changed too :) |
@patchedsoul do you mind responding? |
Is there any progress here? I am having the same issue. @m0ngr31 is there a workaround? |
Also wondering if there is a workaround. I can't get the app to work at all using the provided docker-compose. Tagging: @m0ngr31
|
I resolved some minor string handling that was causing trace backs to be thrown. I reformatted the code to be pep8 compliant too. Since I was submitting this PR, I also swapped the now unmaintained 'pycrypto' for the drop-in replacement, 'pycryptodome'.