-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional methods is_set, unset #23
Comments
Hey, First of all, glad you liked the library. Your proposal seems reasonable to me. You can open a PR. Anyway, open PR, I'll review it and that's it! Glad to have you contributing! Thanks. |
@EliSchleifer how is it going? Let me know if I should do this change instead of you! Thanks |
I can code it up. Probably get you a PR in a couple fays
…________________________________
From: Marin Peko ***@***.***>
Sent: Tuesday, September 7, 2021 1:11:42 PM
To: m-peko/bitflags ***@***.***>
Cc: Eli Schleifer ***@***.***>; Mention ***@***.***>
Subject: Re: [m-peko/bitflags] Additional methods is_set, unset (#23)
@EliSchleifer<https://github.com/EliSchleifer> how is it going? Let me know if I should do this change instead of you! Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#23 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJVCPTBKM4ZPXMD3EPYOHLUAZWX5ANCNFSM5CXNZMZQ>.
|
ok, perfect |
Posted a PR #24 |
Would you be open to a PR that aliased the verbs
unset and is_set. The class is super cool, but contains and remove feel like STL container verbs, and if this is a bitset - I don't need to know the impl underneath. I'd like the verbs to be binary set/unset and is_set.
Thoughts?
The text was updated successfully, but these errors were encountered: