Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional methods is_set, unset #23

Open
EliSchleifer opened this issue Aug 24, 2021 · 5 comments
Open

Additional methods is_set, unset #23

EliSchleifer opened this issue Aug 24, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@EliSchleifer
Copy link

EliSchleifer commented Aug 24, 2021

Would you be open to a PR that aliased the verbs

unset and is_set. The class is super cool, but contains and remove feel like STL container verbs, and if this is a bitset - I don't need to know the impl underneath. I'd like the verbs to be binary set/unset and is_set.

Thoughts?

@m-peko
Copy link
Owner

m-peko commented Aug 25, 2021

Hey,

First of all, glad you liked the library. Your proposal seems reasonable to me. You can open a PR.
We'll need to release new version, possibly 2.0, of the library since this is a breaking change but that's my part of the job.

Anyway, open PR, I'll review it and that's it! Glad to have you contributing!

Thanks.

@m-peko m-peko self-assigned this Aug 25, 2021
@m-peko m-peko added the enhancement New feature or request label Aug 25, 2021
@m-peko
Copy link
Owner

m-peko commented Sep 7, 2021

@EliSchleifer how is it going? Let me know if I should do this change instead of you! Thanks

@EliSchleifer
Copy link
Author

EliSchleifer commented Sep 7, 2021 via email

@m-peko
Copy link
Owner

m-peko commented Sep 8, 2021

ok, perfect

@EliSchleifer
Copy link
Author

Posted a PR #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants