Update setup.py to download pyannote depending on platform #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you, yes sorry about the mac issues. I had originally been designing this for desktop / commerical gpus usage, not PC, since thats quite common in my research area. But seems a lot of people are using whisperx on mac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#540
Breaks Mac platform and arm64 platforms.
Tested by successfully building on my m1 mac doing:
pip install .
And also using Depot (a way to build Dockerfiles remotely, using arm64):
depot build -t whisperx_image . --platform linux/arm64 --load