Skip to content

Commit

Permalink
gRPC: RST_STREAM(NO_ERROR) handling after "trailer only" responses.
Browse files Browse the repository at this point in the history
Similarly to the problem fixed in 2096b21fcd10 (ticket #1792),
when a "trailer only" gRPC response (that is, a response with the
END_STREAM flag in the HEADERS frame) was immediately followed by
RST_STREAM(NO_ERROR) in the data preread along with the response
header, RST_STREAM wasn't properly skipped and caused "upstream
rejected request with error 0" errors.
Observed with "unknown service" gRPC errors returned by grpc-go.

Fix is to set ctx->done if we are going to parse additional data,
so the RST_STREAM(NO_ERROR) is properly skipped.  Additionally, now
ngx_http_grpc_filter() will complain about frames sent for closed
stream if there are any.
  • Loading branch information
p-pautov committed Nov 19, 2020
1 parent 01ed3c3 commit 671cbc1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/http/modules/ngx_http_grpc_module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1969,6 +1969,7 @@ ngx_http_grpc_filter_init(void *data)
}

u->length = 0;
ctx->done = 1;

} else {
u->length = 1;
Expand Down

0 comments on commit 671cbc1

Please sign in to comment.