Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light/dark mode toggle #65

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Add light/dark mode toggle #65

merged 4 commits into from
Oct 29, 2024

Conversation

ssrahul96
Copy link
Contributor

@ssrahul96 ssrahul96 commented Oct 28, 2024

Fixed #61

Added toggle button next to Github link

image image

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mini-qr-code-generator ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 3:54pm

…he meta tag 'color-scheme'

feat(App.vue): refactor dark mode implementation to use a reusable hook 'useDarkModePreference'
feat(style.css): add transition effect for background-color and color properties to improve user experience when switching between dark and light mode
feat(useDarkModePreference.ts): create a reusable hook to handle dark mode preference and system preference changes
@lyqht
Copy link
Owner

lyqht commented Oct 29, 2024

Hi @ssrahul96, thanks for the PR! I've refactored it so that

  • there will be a 3rd toggle for system-preference
  • dark mode button should still be using the app's default color
  • the whole button should be a button element for accessibility rather than an anchor element like github.

CleanShot 2024-10-29 at 23 51 33

@lyqht lyqht merged commit 8844c19 into lyqht:main Oct 29, 2024
3 checks passed
@lyqht lyqht changed the title [ISSUE-61] added toggle theme button -> light & dark Add light/dark mode toggle Oct 29, 2024
@ssrahul96 ssrahul96 deleted the issues-61 branch October 30, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toggle theme button -> light & dark
2 participants