Fixes for musl #19
Open
Fixes for musl #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, its argument is not const, so add const_cast. This is risky because in fact basename() will modify the argument if it ends with / but that's not the case here. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
LONG_BIT is not a sysconf value, it is either 32 or 64. Using it as a sysconf value will give weird results. Also sysconf(_SC_LONG_BIT) is useless: it will always return a value equal to LONG_BIT: it's either compiled 32-bit or 64-bit so a runtime lookup doesn't make sense. For this reason, musl has removed the definition of _SC_LONG_BIT. Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
vapier
suggested changes
Dec 15, 2016
| @@ -99,7 +100,7 @@ static string sysfs_getbustype(const string & path) | |||
| { | |||
| devname = | |||
| string(fs.path + "/bus/") + string(namelist[i]->d_name) + | |||
| "/devices/" + basename(path.c_str()); | |||
| "/devices/" + basename(const_cast<char*>(path.c_str())); | |||
There was a problem hiding this comment.
this is wrong -- when you include libgen.h, you get a POSIX basename which is allowed to modify the memory of the arg passed in. which means this might crash.
might be better to have lshw define its own basename to guarantee portability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cfr. http://autobuild.buildroot.net/results/320/320f0648860c79b5fc8890b85e75a05dc1d1bfeb