Various improvements

[friendly-bits]

This PR is mainly about code maintenance and bugfixes.

Among other things, this fixes a bug with files .abl-extract_blocklist, abl-conf-script not removed when adblock-lean is paused.
Also this adds the .gitattributes file as discussed in #93.

[friendly-bits]

Hi @lynxthecat, reminding about this PR.

[lynxthecat]

At this line here:

adblock-lean/usr/lib/adblock-lean/abl-lib.sh

Line 560 in 1159a3b

REPLY=p

Should we add a comment along the lines: "Unable to suggest a suitable preset. Please pick your own."?

[friendly-bits]

At this line here:

adblock-lean/usr/lib/adblock-lean/abl-lib.sh

Line 560 in 1159a3b

REPLY=p

Should we add a comment along the lines: "Unable to suggest a suitable preset. Please pick your own."?

${preset} will be empty string if get_def_preset() failed, most likely because we failed to detect total memory capacity of the system. In this case, get_def_preset() prints an error message:

adblock-lean/usr/lib/adblock-lean/abl-lib.sh

Line 634 in 1159a3b

''|*[!0-9]*) reg_failure "\$_totalmem has invalid value '${_totalmem}'. Failed to determine system memory capacity."; return 1 ;;

I thought this was sufficient and the user will understand why they are asked to pick a preset. If you think we should add an extra message, no problem.

[lynxthecat]

Yeah I understood that this would occur at least on the failure to detect memory. I mean perhaps it's obvious enough, but I thought perhaps it might be reassuring that the consequence is not dire and only amounts to inability to suggest suitable preset. Just a suggestion from me - I'll leave it with you whether to add or leave as is.

I don't have any other thoughts or suggestions.

[friendly-bits]

All right, I added a log message saying approximately what you suggested (the phrasing is a bit different because this may also occur when setup() is called by the luci app and we need to accommodate that case).

I don't have any other thoughts or suggestions.

Do you mean the whole PR? If so, should we merge?

[lynxthecat]

All right, I added a log message saying approximately what you suggested (the phrasing is a bit different because this may also occur when setup() is called by the luci app and we need to accommodate that case).

Excellent - I like that better than my own suggestion.

Do you mean the whole PR? If so, should we merge?

Yes I think so!