Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same behavior than the deprecated URI.escape #1470

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Use the same behavior than the deprecated URI.escape #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use the same behavior than the deprecated URI.escape
  • Loading branch information
@MaicolBen
MaicolBen committed Mar 6, 2021
commit fb9519f799139cef6aa9ce9f8ba6747606020081
2 changes: 1 addition & 1 deletion app/views/devise_token_auth/omniauth_external_window.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Cordova / PhoneGap)
*/

var data = JSON.parse(decodeURIComponent('<%= CGI::escape( @data.to_json ) %>'));
var data = JSON.parse(decodeURIComponent('<%= ERB::Util.url_encode( @data.to_json ) %>'));

window.addEventListener("message", function(ev) {
if (ev.data === "requestCredentials") {
Expand Down
2 changes: 1 addition & 1 deletion test/controllers/devise_token_auth/omniauth_callbacks_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def get_success(params = {})
follow_all_redirects!

data = get_parsed_data_json
assert_equal "Redirect to &#39;#{@bad_redirect_url}&#39; not allowed.",
assert_equal "Redirect to '#{@bad_redirect_url}' not allowed.",
data['error']
end

Expand Down