New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace URI::escape which was removed in Ruby 3 #1468

Merged

MaicolBen merged 1 commit into lynndylanhurley:master from alea12:master

Mar 6, 2021

Contributor

alea12 commented Feb 27, 2021

URI::escape was removed in Ruby 3.0.0. ruby/uri#9
This PR replaces URI::escape with CGI::escape, making the library compatible with Ruby 3.


          use CGI::escape instead of URI::escape

b1eb531

MaicolBen merged commit 281c91c into lynndylanhurley:master

Collaborator

MaicolBen commented Mar 6, 2021

CGI doesn't work as URI, I realized after I merged (the suite was broken so I didn't know), I made #1470 to fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet