-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable force_layer and re-enable auto padding #903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice! I really like the idea of disabling forced layers, and I like this proposal.
But I don't like the change in the client API though, it gives developers the next wrong ideas IMO:
_setQualityLayer('auto', 2)
it seems like we're setting automating spatial layer switching while forcing the temporal layer._setQualityLayer(0, 'auto')
not sure whether it will work- `_setQualityLayer('auto', 'auto') not sure whether it will work or not
Just a proposal: should we change the API to have two methods to something like this?
_setStaticQualityLayer(1,2)
_setDynamicQualityLayer()
I haven't thought them a lot, but it's just to give you an idea.
Ok, I like your observation. |
It also would be nice to have a preference to set the preferred switch. |
agree, but that's a different API, that would be also nice to have limits on the max resolution and/or framerates each subscriber can receive. |
updated with new Stream.js |
!up please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
Description
It disable the previously forced layers of subscribed simulcast and re-enable the auto padding algo.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
if subscribedStream._setQualityLayer('auto') is passed, it switch to auto.
[] It includes documentation for these changes in
/doc
.