New dockerfile and start script #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Apr 27, 2017
Dockerfile
Outdated
| RUN ./installUbuntuDeps.sh --cleanup && \ | ||
| ./installErizo.sh && \ | ||
| ./../nuve/installNuve.sh && \ | ||
| ./installBasicExample.sh |
…o fix/dockerStartScript
aalonsog
approved these changes
Apr 27, 2017
| sleep 3 | ||
| } | ||
|
|
||
| run_mongo() { |
There was a problem hiding this comment.
Perhaps we can reuse the code in /scripts/installNuve.sh by passing parameters depending on the parts we want to execute. If so we should split the populate code in that scripts in two parts: run mongo and populate mongo.
There was a problem hiding this comment.
I agree that we're duplicating code here, but I would do it as a part of a bigger refactoring of the scripts. Right now the populating the database is tied to copying the configuration and that can cause all sorts of problems if we make it an option in the default scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new Dockerfile and docker init script.
Instead of pulling the repository, the new dockerfile uses
COPYto generate the context for the build.The new script allows for starting different parts of licode as well as starting the whole thing.
You can for instance run it with
--nuveto only start nuve. For now, no further customization of the configuration is provided.For users of the older Dockerfile
This new Dockerfile is located in the root of the repository to be able to generate the context via
COPYAlso,
CMDhas been changed toENTRYPOINTto make it easier to pass parameters to the init script. Remember you have to use--entrypointto change the entrypoint instead of just passing the script as a parameter.[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Add a detailed description of any change in the public APIs.
[] It includes documentation for these changes in
/doc.