Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 813 #824

Merged
merged 4 commits into from
Mar 27, 2017
Merged

Fix 813 #824

merged 4 commits into from
Mar 27, 2017

Conversation

aalonsog
Copy link
Member

Description

This PR fixes issue #813. It also corrects some formatting issues of http responses.

[X] It needs and includes Unit Tests

I've modified the needed tests according to the changes.

Changes in Client or Server public APIs

It justs modifies some error messages in Nuve REST API responses

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! good catch and fix!

@@ -70,4 +70,9 @@ app.get('/rooms/:room/users', usersResource.getList);
app.get('/rooms/:room/users/:user', userResource.getUser);
app.delete('/rooms/:room/users/:user', userResource.deleteUser);

app.listen(3000);
// handle 404 errors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@aalonsog aalonsog merged commit a9d71e9 into lynckia:master Mar 27, 2017
@aalonsog aalonsog deleted the fix_813 branch March 27, 2017 15:16
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants