Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection failed event #1751

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Fix connection failed event #1751

merged 3 commits into from
Sep 7, 2021

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Sep 7, 2021

Description

Properly capture the failed message from the connection and emit a connection-failed event.
[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@lodoyun lodoyun changed the title Fix/connection failed Fix connection failed event Sep 7, 2021
jcague
jcague approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@lodoyun lodoyun merged commit d5b7b65 into lynckia:master Sep 7, 2021
@lodoyun lodoyun deleted the fix/ConnectionFailed branch September 7, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcague jcague jcague approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lodoyun @jcague