Stop padding if the distributor does not assign all the available #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
approved these changes
Apr 19, 2021
| @@ -349,7 +349,7 @@ void QualityManager::forceLayers(int spatial_layer, int temporal_layer) { | |||
| } | |||
|
|
|||
| void QualityManager::enableSlideShowBelowSpatialLayer(bool enable, int spatial_layer) { | |||
| if (enable_fallback_below_min_layer_ == enable && slideshow_below_spatial_layer_ == spatial_layer_) { | |||
| if (enable_fallback_below_min_layer_ == enable && slideshow_below_spatial_layer_ == spatial_layer) { | |||
| @@ -99,6 +100,7 @@ void StreamPriorityBWDistributor::distribute(uint32_t remb, uint32_t ssrc, | |||
| remb, stream_info.stream->getId().c_str(), remaining_bitrate); | |||
| } | |||
| } | |||
| stats_->getNode()["total"].insertStat("unnasignedBitrate", CumulativeStat{remaining_bitrate}); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitrate
Description
This PR addresses an issue where erizo would keep generating padding unnecessarily when using the
StreamPriorityBWDistribution.If the distributor does not use all the available bitrate, the
PaddingManagerwould still assign padding bitrate to the mediaStreams. We don't actually need that since the distributor has already assigned all the needed bitrate according to the defined strategy.This PR addresses this by instructing the
PaddingManagerto stop generating padding when there's unneeded available bitrate after a pass of the distribution algorithm.[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.