Updated mongo and conan versions #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 2, 2019 15:59
lodoyun
reviewed
Mar 10, 2021
scripts/installUbuntuDeps.sh
Outdated
| sudo apt-get install -y libcurl4 openssl liblzma5 | ||
| wget -P $LIB_DIR https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2004-4.4.4.tgz | ||
| tar -zxvf $LIB_DIR/mongodb-linux-x86_64-ubuntu2004-4.4.4.tgz -C $LIB_DIR | ||
| sudo cp $LIB_DIR/mongodb-linux-x86_64-ubuntu2004-4.4.4/bin/* /usr/local/bin/ |
There was a problem hiding this comment.
would symbolic links work? I don't particularly like copying the binaries there when they may change.
Also, this may create new problems with anyone that already has a mongo version installed. We could consider using a suffix or a preffix for the binaries. For every other thing I think we either use a ubuntu package or we keep it in LIB_DIR without affecting /usr/bin or /usr/lib
There was a problem hiding this comment.
I would also add a way to clean everything up in the cleanup function
There was a problem hiding this comment.
Done!! Thanks for the suggestion :)
added 2 commits
March 10, 2021 16:54
Arri98
pushed a commit
to Arri98/licode
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original objective of this PR was to update the MongoDB version installed by Licode scripts to MongoDB v4. This is needed for supporting the new implementation of transactions included in commit a9a29f8.
However, during the update I discovered an Erizo installation issue raised by the incompatibility of the current versions of bzip2 and conan. Thus, I decided to update also the conan version to 1.34. This update implicates the modification of how the conan compiler is passed to the format_include_paths function. This is why I've also modified conanfile.py.
Summarising the PR modifies the following:
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.