Add qualityLevel stat #1617
Merged
Add qualityLevel stat #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
commented
Jul 21, 2020
| @@ -59,6 +59,8 @@ void QualityManager::onConnectionQualityUpdate(ConnectionQualityLevel level) { | |||
| selectLayer(false); | |||
| } | |||
| last_connection_quality_level_received_ = level; | |||
| stats_->getNode()["qualityLayers"].insertStat("currentQualityLevel", | |||
There was a problem hiding this comment.
I've decided to add the stat here in QualityManager. This is where the quality check changes affect the decisions. I could be convinced to put it directly in BandwidthConnectionQualityCheck, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds stat to track QualityLevel.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.