Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to logs #1606

Merged
merged 6 commits into from
Jul 1, 2020
Merged

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Jun 29, 2020

Description

Add more info to logs about metadata and options.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Should make logs significantly more useful.
i do have a few questions in the comments.

@@ -12,7 +12,10 @@ const logFile = global.config.logger.configFile || '../log4js_configuration.json
const logJsonReplacer = (key, value) => {
if (key) {
if (typeof (value) === 'object') {
return '[Object]';
const log = exports.logger.objectToLog(value);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

erizo_controller/erizoJS/erizoJSController.js Outdated Show resolved Hide resolved
erizo_controller/erizoJS/models/Connection.js Outdated Show resolved Hide resolved
erizo_controller/erizoJS/models/Subscriber.js Outdated Show resolved Hide resolved
@jcague jcague merged commit fea9fd3 into lynckia:master Jul 1, 2020
@jcague jcague deleted the fix/lack_of_info_in_logs branch July 1, 2020 08:54
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants