Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make global variables part of window in basicExample #1605

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented Jun 29, 2020

Description

This PR explicitly exposes global variables through window. This is helpful to use basicExample as a test in some environments.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun changed the title Add make global variables part of window in basicExample Make global variables part of window in basicExample Jun 30, 2020
@lodoyun lodoyun merged commit f554a95 into lynckia:master Jun 30, 2020
@lodoyun lodoyun deleted the add/makeGlobalVariablesVisible branch June 30, 2020 07:39
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants