Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information to Room logs #1411

Merged
merged 1 commit into from
May 14, 2019
Merged

Conversation

lodoyun
Copy link
Contributor

@lodoyun lodoyun commented May 14, 2019

Description
Room logs often lack information needed to diagnose issues. This PR adds more info in warning and error logs, making it easier to track issues.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lodoyun lodoyun merged commit 563e584 into lynckia:master May 14, 2019
@lodoyun lodoyun deleted the add/moreLogsInRoom branch May 14, 2019 16:22
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants