Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change DTLSv1_2_method to DTLS_method #1386

Merged
merged 1 commit into from
Apr 2, 2019
Merged

change DTLSv1_2_method to DTLS_method #1386

merged 1 commit into from
Apr 2, 2019

Conversation

lidedongsn
Copy link
Contributor

@lidedongsn lidedongsn commented Mar 22, 2019

refer #1380
mContext = SSL_CTX_new(DTLSv1_2_method());
Chrome under M74 (mine 版本 73.0.3683.75(正式版本) (64 位))got “message: Handshake failed, transportName:video, openSSLerror: error:1409210A:SSL routines:ssl3_get_server_hello:wrong ssl version”
ssl/ssl.h
const SSL_METHOD DTLS_method(void); / DTLS 1.0 and 1.2 */
should be ok

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

[] It includes documentation for these changes in /doc.

@jcague
Copy link
Contributor

jcague commented Mar 22, 2019

I don't see that issue with chrome 73.0.3683.86. We actually need this change to keep compatibility with newer versions.

@alokp
Copy link

alokp commented Mar 26, 2019

@jcague this PR might be a better solution because per the docs DTLS_method() supports both DTLS v 1.0 and v1.2 but DTLSv1_2_method() will not work with the DTLS v1.0 clients.

@jcague
Copy link
Contributor

jcague commented Apr 1, 2019

@lidedongsn sorry I was wrong with this code. I didn't realize there's a generic method to use both versions. Will try it locally to check it in my local env with newer versions of chrome. Thanks for the contribution!

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it also works for Chrome v75, thanks a lot!

@jcague jcague merged commit e0c0bd0 into lynckia:master Apr 2, 2019
jcague pushed a commit that referenced this pull request Apr 5, 2019
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants