Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unresolved promises and some minor fix #1385

Merged
merged 20 commits into from
Apr 1, 2019
Merged

Fix unresolved promises and some minor fix #1385

merged 20 commits into from
Apr 1, 2019

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Mar 21, 2019

Description

This PR fixes these issues:

  • A promise was not always being resolved in WebRtcConnection.
  • Potential unresolved promises using AsyncPromiseWorker in ErizoAPI.
  • Negotiation kept blocked if the first offer failed to be applied. I add some checks all the way from ErizoClient to ErizoJS.
  • ResendLastAnswer mechanism did not stop ever in case that something strange happens, which causes lots of logs in the server.

[] It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

lodoyun
lodoyun approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

lodoyun
lodoyun approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can see a bunch of places where errors are better handled 👍

@jcague jcague merged commit 2365d9e into lynckia:master Apr 1, 2019
@jcague jcague deleted the fix/unresolved_promises_and_paths_in_negotiation branch April 1, 2019 15:31
jcague added a commit that referenced this pull request Apr 24, 2019
@jcague
Fix unresolved promises and some minor fix (#1385)
50a2719
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
@jcague
Fix unresolved promises and some minor fix (lynckia#1385)
90bcb14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lodoyun lodoyun lodoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcague @lodoyun