When closing streams, also unbind from all events. #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcague
reviewed
Jun 28, 2018
| @@ -49,6 +49,7 @@ const EventDispatcher = () => { | |||
| that.on = that.addEventListener; | |||
| that.off = that.removeEventListener; | |||
| that.emit = that.dispatchEvent; | |||
| that.unbindEvents = () => { dispatcher.eventListeners = {}; }; | |||
There was a problem hiding this comment.
I think that a name like removeAllListeners() would be more similar to the rest of methods here. wdyt?
Could you also move it to line ~35, just below removeEventListener() {...} block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When closing a stream we are currently NOT unbinding from this:
licode/erizo_controller/erizoClient/src/Room.js
Line 126 in 18c5562
Steps to reproduce:
tab 1) Publisher
tab 2) subscriber. Subscribe to remote stream, then unsubscribe, then subscribe again. 2 stream added events are fired
[] It needs and includes Unit Testsì
Changes in Client or Server public APIs
[] It includes documentation for these changes in
/doc.