-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build script to automatically detect number of CPUs #1226
Conversation
erizo/generateProject.sh
Outdated
if [ -d $BIN_DIR ]; then | ||
cd $BIN_DIR | ||
else | ||
if [ ! -d $BIN_DIR ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the issue with the previous way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this way cmake is called only the first time that the folder is created after a cleaonOject is called.
I noticed that if cmake is run every time generateProject is called, it build the enteire project every time instead of only the changes made in cpp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just run buildProject.sh if you implement changes inside existing cpp files, or run generateProject.sh if you add/remove files or dependencies. With this change it won't regenerate cmake structure if the directory already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok it makes sense.
I left all the things needed to do a "power" compile but @jcague why in the "old" v2, installErizo.sh -e, even redoing the cmake, didn't recompile everything but only changes? |
I don't remember exactly, we probably changed CMakeLists in some way by adding more deps, and it now recreates everything from scratch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Avoiding calling cmake at every ./installErizo.sh allow us to build only the changes that are made between every make and speed up our developing process.
If we want to clear cache with can always run installErizo with -d option