Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build script to automatically detect number of CPUs #1226

Merged
merged 12 commits into from
Jun 7, 2018
Merged

Update build script to automatically detect number of CPUs #1226

merged 12 commits into from
Jun 7, 2018

Conversation

kekkokk
Copy link
Contributor

@kekkokk kekkokk commented May 22, 2018

Avoiding calling cmake at every ./installErizo.sh allow us to build only the changes that are made between every make and speed up our developing process.

If we want to clear cache with can always run installErizo with -d option

if [ -d $BIN_DIR ]; then
cd $BIN_DIR
else
if [ ! -d $BIN_DIR ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the issue with the previous way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this way cmake is called only the first time that the folder is created after a cleaonOject is called.
I noticed that if cmake is run every time generateProject is called, it build the enteire project every time instead of only the changes made in cpp.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just run buildProject.sh if you implement changes inside existing cpp files, or run generateProject.sh if you add/remove files or dependencies. With this change it won't regenerate cmake structure if the directory already exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok it makes sense.

@kekkokk
Copy link
Contributor Author

kekkokk commented Jun 4, 2018

I left all the things needed to do a "power" compile

but @jcague why in the "old" v2, installErizo.sh -e, even redoing the cmake, didn't recompile everything but only changes?

@jcague jcague changed the title Fix build script and generation of Eclipse CDT (2) Update build script to automatically detect number of CPUs Jun 7, 2018
@jcague
Copy link
Contributor

jcague commented Jun 7, 2018

I don't remember exactly, we probably changed CMakeLists in some way by adding more deps, and it now recreates everything from scratch.

Copy link
Contributor

@jcague jcague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcague jcague merged commit 69ff387 into lynckia:master Jun 7, 2018
@kekkokk kekkokk deleted the fix/build branch June 7, 2018 10:21
zevarito pushed a commit to zevarito/licode that referenced this pull request Jul 4, 2018
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants