Add option to set limit of Erizos per Room #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodoyun
approved these changes
Apr 11, 2018
scripts/licode_default.js
Outdated
| @@ -82,6 +82,7 @@ config.erizoController.listen_port = 8080; //default value: 8080 | |||
|
|
|||
| config.erizoController.exitOnNuveCheckFail = false; // default value: false | |||
| config.erizoController.allowSinglePC = false; // default value: false | |||
| config.erizoController.maxErizosInRoom = 0; // default value: 0 | |||
There was a problem hiding this comment.
Consider maxErizosUsedByRoom
| erizos = {}, | ||
|
|
||
| maxErizos = spec.maxConnections || global.config.erizoController.maxErizosInRoom, |
There was a problem hiding this comment.
Why use maxConnections? It's probably clearer if we use a name closer to the one in the config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an option in the config file to set a limit of Erizos per room.
[] It needs and includes Unit Tests
Changes in Client or Server public APIs
Not needed.
[] It includes documentation for these changes in
/doc.