Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ErizoAgent with a new list of ErizoJS #1192

Merged
merged 4 commits into from
Apr 10, 2018

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Apr 10, 2018

Description

Refactoring ErizoAgent to better handling ErizoJSs and processes. It manages a single list with ErizoKS (idle or not) and their processes.

  • It needs and includes Unit Tests

Changes in Client or Server public APIs

Not needed.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A lot more polished than the previous list 👍 . Check the possible typo in comments

});

log.info('message: launched new ErizoJS, erizoId: ' + id);
processes[id] = erizoProcess;
idleErizos.push(id);
erizos.process = erizoProcess;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be erizo.process = erizoProcess; ?

@jcague jcague merged commit 3118a58 into lynckia:master Apr 10, 2018
@jcague jcague deleted the update/erizojs_list_within_agent branch April 10, 2018 14:30
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants