Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to configure codecs per room #1051

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

jcague
Copy link
Contributor

@jcague jcague commented Oct 11, 2017

Description

This PR adds support to configure codecs per room, instead of having the same codec configuration for all rooms in a Licode instance. The list of available configurations will be setup in the rtp_media_config.js file, and we can add/remove the proposed configurations in rtp_media_config_default.js.

The proposed configurations are:

mediaConfig.codecConfigurations = {
  default: { rtpMappings: { vp8, opus }, extMappings },
  VP8_AND_OPUS: { rtpMappings: { vp8, opus }, extMappings },
  VP9_AND_OPUS: { rtpMappings: { vp9, opus }, extMappings },
  H264_AND_OPUS: { rtpMappings: { h264, opus }, extMappings },
};

But we could also add other examples like:

  VP8_AND_PCMU: { rtpMappings: { vp8, pcmu }, extMappings },
  • It needs and includes Unit Tests

Changes in Client or Server public APIs

Now we can specify which media configuration we want to use in a Room.

N.API.createRoom(roomName, function(room) {
  console.log('Room created with id: ', room._id);
}, errorCallback, {mediaConfiguration: 'VP8_AND_OPUS'});

NOTE: If no mediaConfiguration is passed or it doesn't exist in the config file we will use the default one.

[] It includes documentation for these changes in /doc.

Copy link
Contributor

@lodoyun lodoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like this way of having different configurations available 👍

@mkhahani
Copy link
Contributor

Great feature! Thank you.

Copy link
Member

@aalonsog aalonsog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jcague jcague merged commit b3e27cc into lynckia:master Oct 16, 2017
@jcague jcague deleted the add/codec_configuration_per_room branch October 16, 2017 08:06
Arri98 pushed a commit to Arri98/licode that referenced this pull request Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants