compile and test with latest tooling #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
How does this relate to #49? Did the upstream tooling resolve the JavaScript deps issue? |
Owner
|
Ah, I just saw your pull request for Singult. I'll push up a new SNAPSHOT for that library and test out your C2 updates. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump dependencies since clojurescript now requires clojure 1.5.1.
I also updated the clojurescript tests to use
bind!and->dom.It seems that we can't use plain
:idas a key function inunify, it complains at run time that it is not a function. Maybe some inlining thing? It works wrapped as#(:id %)which is what I did intest/integration/cljs/core_test.cljs