add kms performance parameters #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonpetgrave64
changed the title
ramonpetgrave64
changed the title
ramonpetgrave64
changed the title
skiptomyliu
reviewed
Oct 19, 2023
kmsauth/__init__.py
Outdated
| endpoint_url=None, | ||
| token_cache_size=4096, | ||
| stats=None, | ||
| max_pool_connections=100, |
Member
There was a problem hiding this comment.
we should make these defaults to match the boto defaults. Then override as needed.
There was a problem hiding this comment.
https://botocore.amazonaws.com/v1/documentation/api/latest/reference/config.html
defaults
max_pool_connections = 10
connect_timeout = 60 (seconds)
read_timeout = 60 (seconds)
(whoops just saw you already had this in the description, mb)
| read_timeout=1, | ||
| ): | ||
| """Create a KMSTokenValidator object. | ||
|
|
There was a problem hiding this comment.
we should probably also document these new parameters
skiptomyliu
previously approved these changes
Oct 19, 2023
alejandroroiz
approved these changes
Oct 19, 2023
ramonpetgrave64
added a commit
to lyft/confidant
that referenced
this pull request
Oct 20, 2023
Followup to lyft/python-kmsauth#18 Start using the new performance parameters in kmsauth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Editing the
KMSTokenValidatorto allow the botoConfigobject to customizable.For a web server use case, such as within lyft/confidant, some good values are
The boto defaults are 10, 60, 60 respectively.