Skip to content

Comments

fixes 'ValueError: too many values to unpack' for bless_client args#30

Closed
mayn wants to merge 67 commits intolyft:lyft_basefrom
mayn:issue-blessclient
Closed

fixes 'ValueError: too many values to unpack' for bless_client args#30
mayn wants to merge 67 commits intolyft:lyft_basefrom
mayn:issue-blessclient

Conversation

@mayn
Copy link

@mayn mayn commented Jan 9, 2017

when passing in a kmsauth token as part of the arguments, bless client will generate an error.

Traceback (most recent call last):
  File "./bless_client.py", line 91, in <module>
    main(sys.argv[1:])
  File "./bless_client.py", line 50, in main
    bastion_command, public_key_filename, certificate_filename = argv
ValueError: too many values to unpack

Chris Steipp and others added 30 commits August 1, 2016 15:27
Adding compiled libs and make_ca.sh
c3982e7
Authenticate username before issuing cert
d5e4b14 
To prevent users from issuing certs for another user, authenticate the
requested username. Using kmsauth (https://github.com/lyft/python-kmsauth)
the user can be in a separate AWS account, as long as the Lambda is allowed
to decrypt using the configured KMS key.
@acmcelwee
Update bless_client.py to be a little more flexible
0b51f41 
* Allow bless_client.py to use ~/.aws/credentials.
* Use LogType=None because the logs generally live in another account.
* Support  specification of multiple bastion ips and include the bastion
ips in the source-address Critical Options
update kmsauth to use bless servicename
c39306d
Add configs to repo
5d5178a
Adding compiled libs and make_ca.sh
a0463c8
Authenticate username before issuing cert
8aea272 
To prevent users from issuing certs for another user, authenticate the
requested username. Using kmsauth (https://github.com/lyft/python-kmsauth)
the user can be in a separate AWS account, as long as the Lambda is allowed
to decrypt using the configured KMS key.
@acmcelwee
Update bless_client.py to be a little more flexible
21f3c6b 
* Allow bless_client.py to use ~/.aws/credentials.
* Use LogType=None because the logs generally live in another account.
* Support  specification of multiple bastion ips and include the bastion
ips in the source-address Critical Options
update kmsauth to use bless servicename
591fdf7
Add configs to repo
898b720
Merge Netflix master changes
15c0f49
Update make_ca.sh for multiregion
8674996
Handle mutliregional kmsauth
32e27fd
Allow cidr blocks in ip validation
61d48bc
Fix cross-region kmsauth key
42f88e4
@vivianho
Use a single name for kmsauth service 'to' context
cbdd04e
@vivianho
syntax error
eb8e3ee
@vivianho
fixed a test
a9e2224
@vivianho
Merge pull request #2 from lyft/SEC-619-use-single-name-for-kmsauth-s…
aaeaa31 
…ervice

[SEC-619] use single name for kmsauth service
Bump kmsauth version to 0.1.7
9963289
Update all aws_lambda_libs
782b0a2
Re-add with all the crypto pieces
3c304e2
@Stype
Merge pull request #3 from lyft/lyft_base-bump-kmsauth
dc2b475 
Bump kmsauth version to 0.1.7, update all included libs
@vivianho
added a doc for deploying lambda
9006fe1
Refactor kmsauth integration
f5367b0
Add us-west-2 kmsauth key to kmsauth_key_id list
f8eafe7
@Stype
Merge pull request #4 from lyft/SEC-634-lyft-docs
842f348 
[SEC-634] Added a doc for deploying lambda
@Stype
Merge pull request #5 from lyft/lyft_base_kmsauth-updates
8c2f461 
Kmsauth refactor, add us-west-2 keys
@vivianho
fixed typos in lyft readme
cf607ed
@vivianho
Merge pull request #7 from lyft/fixed-typos-in-lyft-readme
153cba7 
fixed typos in lyft readme
vivianho and others added 27 commits September 30, 2016 16:24
@vivianho
updated kmsauth key
4c87f26
@vivianho
Merge pull request #14 from lyft/bump-kmsauth-key-id
e12b118 
Updated kmsauth key
@vivianho
added test option to lambda request
52d4690
@vivianho
instead of a test flag, look for a test user
8f1a561
@vivianho
made or more explicit
30964c6
@vivianho
Merge pull request #15 from lyft/SEC-616-lambda-test-mode
d6cadd7 
Added option to add test user to bless lambda
@vivianho
added lambda info line to print request immediately after lambda is i…
8f0fb34 
…nvoked
@vivianho
Merge pull request #16 from lyft/SEC-868-add-info-request-line
e5ff609 
Added info line to print request immediately after lambda invocation
@vivianho
updated setup.py
d3be4b2
@vivianho
Merge pull request #17 from lyft/hotfix-fix-setup-py
4e22acf 
Updated setup.py
@vivianho
removed aws lambda libs and configs from public repo
6043ef6
@vivianho
Merge pull request #18 from lyft/SEC-870-remove-libs-and-config
8026587 
Removed aws lambda libs and configs from public repo
SEC-869 Gracefully handle anticipated kmsauth errors
cc2afb6
import exception
48d856d
@Stype
Merge pull request #20 from lyft/sec-869
0c7de34 
[SEC-869] Catch anticipated kmsauth errors
@vivianho
updated log line
1d0ea00
@vivianho
Merge pull request #22 from lyft/updated-log-line
9ca1ad0 
updated log line
@vivianho
removed make_ca script from lyft_base
39595ba
@vivianho
catch clienterror from boto
ae53a9b
@vivianho
fixed failing test
e003b24
@vivianho
Merge pull request #23 from lyft/fix-test
9570e17 
Fixed failing test
@vivianho
merged with master
86ec3bf
@vivianho
Merge pull request #24 from lyft/catch-service-unavailable-exception
ea940f8 
Catch service unavailable exception
@vivianho
catch validation error and exit gracefully
e2fe0f4
@vivianho
rename validationerror -> inputvalidationerror
65ce8d5
@vivianho
Merge pull request #26 from lyft/catch-validation-error
7e9a991 
Catch validation error
fixes 'ValueError: too many values to unpack' for args
0c657a0
@Stype Stype closed this in 7271307 Mar 15, 2017
Stype pushed a commit that referenced this pull request Mar 15, 2017
@russell-lewis
Merge pull request #31 from mayn/ISSUE-30
0f68e42 
fixes #30 : add coveralls for test coverage reporting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mayn @acmcelwee @vivianho @Stype