Skip to content

Conversation

@mre
Copy link
Member

@mre mre commented Mar 2, 2025

Refactor the dump-inputs functionality to print all files checked for links and implement file path retrieval with extension filtering in the Input module.

I added this because it was hard to troubleshoot the extension changes, but I figured it would also be helpful to people who want to see which files would be checked when they write lychee ..

As an added benefit, dump-inputs now behaves more like the check command and properly ignores hidden files etc.

This is a follow-up to #1559.
Closes #1767.

Base automatically changed from extensions to master March 2, 2025 16:47
@mre mre requested a review from thomas-zahner March 2, 2025 22:48
@mre mre force-pushed the extensions-refactor branch from b68e5c3 to bfd0094 Compare May 19, 2025 08:52
Copy link
Member

@thomas-zahner thomas-zahner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew, that's quite a lot of changes. I didn't check every single detail nor did I test it locally. Are the existing tests covering the changes? I just see that you made a lot of changes and didn't add any tests but removed some.

@mre mre force-pushed the extensions-refactor branch from bfd0094 to 7a40abf Compare May 23, 2025 20:43
@mre mre requested a review from thomas-zahner May 23, 2025 23:18
@mre mre force-pushed the extensions-refactor branch from 336ea8a to 280571f Compare July 25, 2025 18:40
@mre
Copy link
Member Author

mre commented Jul 27, 2025

From my side, this is ready to be merged. I changed get_file_paths to get_input_sources, which yielded a much cleaner design. Thanks for the tip, @thomas-zahner.

The Docker image is currently failing because of #1774 and I hope it will be fixed with the next lychee release (0.20.0).

@mre mre requested a review from thomas-zahner July 27, 2025 14:30
Copy link
Member

@thomas-zahner thomas-zahner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 and actually fixes #1767

@mre mre force-pushed the extensions-refactor branch from fe6e4ef to 99ee4df Compare August 14, 2025 19:22
@mre
Copy link
Member Author

mre commented Aug 17, 2025

Here I was, thinking that this would be a 10-minute change. So many edge-cases and caveats (and distractions, I guess)!
What a lift.

Anyway, this is finally ready now. As always, thanks for the thoughtful review @thomas-zahner.

@mre mre merged commit 62f2193 into master Aug 17, 2025
5 of 6 checks passed
@mre mre deleted the extensions-refactor branch August 17, 2025 12:09
This was referenced Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dumping behaves differently compared to link checking

3 participants