Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interesting projects who use lychee #1537

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

thomas-zahner
Copy link
Member

Today I encountered some interesting projects using lychee

@mre
Copy link
Member

mre commented Oct 20, 2024

@thomas-zahner
Copy link
Member Author

Ah didn't know that 👍

@thomas-zahner
Copy link
Member Author

I've added the link just to the repo, not the full path where lychee is used for consistency. Would you prefer all links pointing to a lychee config or the workflow file so one can quickly see how lychee is used in that project?

Also the links are getting more numerous in the README (and maybe other places as well?). Maybe we could consider adding lychee's GitHub action to lychee? Maybe something equivalent to lychee --exclude-path benches --exclude-path fixtures . --verbose

@mre mre merged commit 1f2df5d into lycheeverse:master Oct 21, 2024
6 of 7 checks passed
@mre
Copy link
Member

mre commented Oct 21, 2024

Great list, thanks!

I like the idea of using lychee-action and the proposed config. Let's do that to in a separate pull request.

I think linking to the repos makes sense as the config files could be renamed. We could have a separate config showcase on the lychee website at some point.

@thomas-zahner
Copy link
Member Author

@mre Thanks for merging. I agree with all you said.

Actually it seems like we already do link checking. See .github/workflows/links.yml. So I'll just adjust the args so that everything except the benches and fixtures directories are checked. Is this fine?

@mre
Copy link
Member

mre commented Oct 23, 2024

Aye. Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants