Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a new tab instead of closing the app in dropdown mode #208

Closed
wants to merge 2 commits into from
Closed

Open a new tab instead of closing the app in dropdown mode #208

wants to merge 2 commits into from

Conversation

f2404
Copy link
Contributor

@f2404 f2404 commented Jan 28, 2016

Fixes #154

@jleclanche
Copy link
Member

That... doesn't seem right at all.

@f2404
Copy link
Contributor Author

f2404 commented Jan 28, 2016

Why? I see it's implementing the request.

@pvanek
Copy link
Contributor

pvanek commented May 25, 2016

It seems strange to me. But I'm not dropdown user...

@agaida
Copy link
Member

agaida commented Oct 3, 2016

@f2494 - could you resolve the conflicts please - @pvanek: looks strange, but is imho the right and expected behaviour.

@f2404
Copy link
Contributor Author

f2404 commented Oct 4, 2016

@agaida Rebased.

agaida
agaida previously approved these changes Oct 4, 2016
@agaida
Copy link
Member

agaida commented Oct 5, 2016

tested this and see to many glitches - the idea is good, but the code not (yet)
https://bugs.siduction.org/attachments/download/272/vokoscreen-2016-10-05_20-06-27.mkv

Sorry, was to fast with my approval - and that lead to the next question - how to undo/remove an approval?

@f2404
Copy link
Contributor Author

f2404 commented Oct 6, 2016

@agaida Please check the latest commit.

@agaida
Copy link
Member

agaida commented Nov 17, 2016

@f2404: Works for me

@palinek @pmattern @paulolieuthier - could you test too?

@pmattern
Copy link
Contributor

Closing a second (regular) window which had been opened from a QTerminal "window" in drop-mode before terminates the QTerminal instance altogether. Don't know whether this is expected behavior.

That aside f2404/qterminal@aa01554e seems to behave as asked for in #154. But I'm probably not the right person to judge that whole thing because I still think the behavior proposed here is just plain wrong.

@pmattern
Copy link
Contributor

Meanwhile I do think this new feature is a good thing as well.

@f2404
(Assuming you are not too annoyed by this PR celebrating its first birthday some days ago:)
What I wrote above (first paragraph) wasn't accurate. When another "regular" instance is launched by invoking qterminal & in a drop-down terminal and this additional instance is terminated, the instance in drop-down mode is not terminated as well. Rather, the key to make the drop-down instance visible seems to get disabled. Isn't this worth having another look at?
Any chance you can turn the new feature into an option? Could very well be enabled by default. As for the location within the settings I'd suggest an additional new topic at Behaviour (left pane) - Behaviour (section in right pane).
Sure enough the commits have to be rebased by now as well.

@agaida agaida dismissed their stale review January 14, 2018 21:44

all in all not the right approach

@agaida agaida closed this Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants