-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open a new tab instead of closing the app in dropdown mode #208
Conversation
That... doesn't seem right at all. |
Why? I see it's implementing the request. |
It seems strange to me. But I'm not dropdown user... |
@f2494 - could you resolve the conflicts please - @pvanek: looks strange, but is imho the right and expected behaviour. |
@agaida Rebased. |
tested this and see to many glitches - the idea is good, but the code not (yet) Sorry, was to fast with my approval - and that lead to the next question - how to undo/remove an approval? |
@agaida Please check the latest commit. |
@f2404: Works for me @palinek @pmattern @paulolieuthier - could you test too? |
Closing a second (regular) window which had been opened from a QTerminal "window" in drop-mode before terminates the QTerminal instance altogether. Don't know whether this is expected behavior. That aside f2404/qterminal@aa01554e seems to behave as asked for in #154. But I'm probably not the right person to judge that whole thing because I still think the behavior proposed here is just plain wrong. |
Meanwhile I do think this new feature is a good thing as well. @f2404 |
Fixes #154